I just do the odd song now for my own enjoyment and to put on youtube. Even on youtube if you are not known, your dog or cat is likely to get more hits. A lot of stuff anyways is driven by social media such as facebook in conjunction with youtube. For example the singing priest that got over 30 million hits on youtube recently was helped greatly by facebook shares.
As regards writing songs and sending them to singers to record or to consider I have totally given up on that. To be honest most of the time there is no response. Even if it is a good song the singer will get all the glory and the songwriter is still a nobody (maybe the exception in the case of a massive hit)
That is not to say if someone heard my song on youtube and wanted to record it, I would say go ahead no problem, wouldn't be too bothered if they made any money out of it either.
As regards the formula for writing a good song I think the old adage still goes, it has got to be simple enough, catchy enough, a nice maybe even simple melodic line, for the guy driving the pickup truck down the road to sing.
As regards doing songwriting courses such as the Pat Patisson course which I have done bits of (and I know is well respected on here) I just consider that pure drudgery and for me totally takes the fun out of writing the song, and I just stopped his course. God knows if he has all the answers then why is he not drowning in hits. That saying he is a lovely guy to listen to and some of his little stories are great. But his course just drove me crazy.On the other hand the music production course by Louden Stearns was a real eye opener for me, couldn't get enough of it, but everyone to their own as people are different.
I do think that eventually some one will make it big because of streetjelly that kind of website, (how's your site coming on Pat if you are reading this?)
Anyways I think the main thing we all try out hand at this is for fun, and other than buying biab and a few other small items I don't throw any money atall at it.
Just my thoughts.
Musiclover